Calling activate_field on choices_click, fixes #1729 #1731
Conversation
|
It would be great if you guys accept this PR. This issue is annoying. |
|
I just went ahead and rebased this branch to bring it up to date with the latest from master. Let me know if I can answer any questions. |
|
I hadn't thought of this, but @efedorenko mentioned in #2003 that clicking on I don't think it's as bad of a usability issue as not being able to set focus by clicking inside the visible text field, but it may be a good idea to set focus on this event also. In general, I think we should strive to maintain focus on that text field as long as the user is interacting with that instance of Chosen; I think clicking on an empty results list falls under that umbrella. Thoughts? Should we call |
|
@harvesthq/chosen-developers, @stof; got anything against merging this? |
|
+1, we're affected by #1729 and this seems to fix the problem - would love to see this merged! |
|
Wow, this was on of the first pull requests I ever submitted to an open source project—a little over three years ago. Thanks for merging this! |
Fixes #1729 simply by sending focus to
.search-field inputwhen clicking.chosen-choices.At first, I imagined two possible solutions to this issue:
.search-field inputto fill the width of.chosen-choicesminus the width of any currently selected values..search-field inputwhen clicking.chosen-choices.The first option was not selected as it was more complicated and it would fail to address the case of clicking inside the red circled area in the following screenshot:
